HDDS-13829. Audit file rollover does not happen at the start of a new day#9190
Merged
adoroszlai merged 1 commit intoapache:masterfrom Nov 19, 2025
Conversation
Contributor
|
The change looks good to me. Still draft? |
|
LGTM |
adoroszlai
changed the title
Contributor
|
Thanks @ptlrs for the patch, @ChenSammi, @sumitagrawl, @yandrey321 for the review. |
ptlrs
deleted the
HDDS-13829-The-audit-file-rollover-does-not-happen-at-the-start-of-a-new-day
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR makes the changes so that the rollover happens at the start of the new date instead of after 24 hours of starting the java process.
As per the existing policy we rollover after 86400 seconds.
This means that if we start our process at 3 PM on a given day (1), the rollover to the next date will happen after 86400 seconds on next day (2) at 3PM.
Due to this Day 2's logs from 12AM-3PM will be in the Day 1's log files. This is incorrect.
We want the rollover to happen when the next day starts so that all Day 2's logs are in their own separate files.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-13829
How was this patch tested?
CI: https://github.com/ptlrs/ozone/actions/runs/18735554050